This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Report the affected resources for each event #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hitherto we have used a single list of `ResourceID`s to populate the event field. It was calculated by looking at which files have changed since last sync, and which resources are in those changed files. This is inaccurate because 1. files don't always contain one resource (though currently, files _we can change_ only contain one resource) 2. each event gets the list of resources changed in _any_ commit. To address 2., use the Result field from the git note, which has a record of what was actually changed in that operation. 1.) is less of a problem for now, because we can only change files containing one resource at present anyway.
aaron7
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitherto we have used a single list of
ResourceIDs to populate theevent field. It was calculated by looking at which files have changed
since last sync, and which resources are in those changed files.
This is inaccurate because
we can change only contain one resource)
To address 2., use the Result field from the git note, which has a
record of what was actually changed in that operation.
1.) is less of a problem for now, because we can only change files
containing one resource at present anyway.
Fixes #729.