This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Verify container changes #1094
Merged
Verify container changes #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
approved these changes
May 24, 2018
release/errors.go
Outdated
| for those limitations. | ||
|
|
||
| If your files appear to meet the requirements, it may simply be a bug | ||
| in Flux. PLease report it at |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
release/releaser.go
Outdated
| updates, results, err := changes.CalculateRelease(rc, logger) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| err = ApplyChanges(rc, updates, logger) | ||
| if err == nil { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
release/releaser.go
Outdated
|
|
||
| beforeWorkload, ok := beforeRes.(resource.Workload) | ||
| if !ok { | ||
| continue |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@aaron7 PTAL, and I will autosquash if you're happy. |
lgtm |
This commit fills in the detail of verifying releases, by comparing the model before with the model after to make sure only the intended changes have been made.
The minimal test that if the release doesn't work (in this case, nothing is updated), verification will fail.
squaremo
force-pushed
the
issue/1081-verify-container-changes
branch
from
b38d988
to
ea14a1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a verification step to the release process. The verification step checks that exactly the changes that were intended were made to the files in the git repo clone. This guards against the file update code doing something silly, like changing every container in a deployment, and this being committed.
Fixes #1081.