This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Get image pull secrets via serviceAccounts #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible, and often more economical, to give ImagePullSecrets to a service account (perhaps the default for the namespace), rather than each workload individually. So that flux will still find these secrets, look up the service account, and its imagePullSecrets, if any. This involves one more RPC to the API server (to get the service account), per workload.
Each time we refresh the list of images to fetch metadata for, we do this:
* create a map of image->credentials
* for each workload,
* look up all the imagePullSecrets associated with it and merge
them together into credentials
* for each image used in the workload, merge with the entry in the
map for that image
This works, but it uses far more API calls than it really needs to,
because secrets are very likely to be reused as imagePullSecrets for
different workloads.
To avoid doing extra lookups, keep track of secrets already seen
within each namespace, and don't ask for them again when they are
mentioned afterwards.
A minor refactor to pull these apart a little and make testing (and further separation) easier.
This rationalises the use of the Kubernetes' client in kubernetes.Cluster by using the pre-made clientset, rather than a bunch of individual interfaces.
This makes it a bit easier to track down problems.
- do we get creds that are mentioned as ImagePullSecrets in the pod spec? - do we get creds that are mentioned as ImagePullSecrets in the service account?
|
Cheers 🎇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible, and often more economical, to give ImagePullSecrets to
a service account (perhaps the default for the namespace), rather than
each workload individually.
So that flux will still find these secrets, look up the service
account, and its imagePullSecrets, if any. This involves one more RPC
to the API server (to get the service account), per workload.
Fixes #1043.