-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
EDIT: Nope, right the first time. I fooled myself by applying a weave cloud config, which of course uses the released daemon and thus doesn't understand this argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
daemon/images.go
Outdated
return ids | ||
} | ||
|
||
// getUnlockedAutomatedServices returns all the resources that are |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
The idea is to let people overlay bits of configuration by supplying more than one `--git-path` argument. Much of the machinery for dealing with manifest files (and directories) already expected more than one path; but, it wasn't necessarily convenient to supply all of them in one go, so I've updated the Manifests interface and followed that through. The git path appears in API results -- it's just an opaque string, though, so joining the now multiple paths and returning that should be fine.
5f2de14
to
8f09ae6
Compare
Rebassed and cliffhanger comment resolved. |
Just wondering:
|
Possibly only the usage message :-S |
The idea is to let people overlay bits of configuration by supplying more than one
--git-path
argument.Much of the machinery for dealing with manifest files (and directories) already expected more than one path; but, it wasn't necessarily convenient to supply all of them in one go, so I've updated the Manifests interface and followed that through.
The git path appears in API results -- it's just an opaque string, though, so joining the now multiple paths and returning that should be fine.
Fixes #1267.