This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Correctly store Excluded manifests #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that fluxd was continually fetching image manifests that were "excluded", that is, had the wrong arch or otherwise weren't suitable. The design in #1265 was to mark those manifests as excluded, but count them as successful fetches; and, to save the fact in memcached. The implementation failed on three counts: - it would unconditionally use a cached result, even if excluded; - it was using the ID from excluded results (which have no ID value) as a key, so they got effectively thrown away anyway; - the encoding of results to JSON omitted the ExcludedReason field, because they embed the image.Info struct and thus inherit its JSON encoding methods. This commit corrects those problems.
|
@rndstr Would you have a look at this when you have some review-time, please? |
rndstr
approved these changes
Sep 11, 2018
|
Thanks for the review, Roli 🍏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that fluxd was continually fetching image manifests that
were "excluded", that is, had the wrong arch or otherwise weren't
suitable.
The design in #1265 was to mark those manifests as excluded, but count
them as successful fetches; and, to save the fact in memcached. The
implementation failed on three counts:
it would unconditionally use a cached result, even if excluded;
it was using the ID from excluded results (which have no ID value)
as a key, so they got effectively thrown away anyway;
the encoding of results to JSON omitted the ExcludedReason field,
because they embed the image.Info struct and thus inherit its JSON
encoding methods.
This commit corrects those problems.