Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Improve commit message for containers releases #1479

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Oct 26, 2018

Changes the Git commit message for containers release from

Release containers

default:deployment/foo
- quay.io/bar/nginx:master-d9500ad8
- quay.io/bar/logger:master-d9500ad8

default:deployment/moo
- quay.io/bar/nginx:master-d9500ad8

to

Update image refs in default:deployment/foo, default:deployment/moo

default:deployment/foo
- quay.io/bar/nginx:master-d9500ad8
- quay.io/bar/logger:master-d9500ad8

default:deployment/moo
- quay.io/bar/nginx:master-d9500ad8

Closes #1478

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're improving the commit message, can you make it say something other than "Release containers" -- which is nonsensical (or at least doesn't describe what has been done). "Update images refs in " would be better, I think.

Changes the Git commit message for containers release from

```
Release containers

default:deployment/foo
- quay.io/bar/nginx:master-d9500ad8
- quay.io/bar/logger:master-d9500ad8

default:deployment/moo
- quay.io/bar/nginx:master-d9500ad8
```

to

```
Update image refs in default:deployment/foo, default:deployment/moo

default:deployment/foo
- quay.io/bar/nginx:master-d9500ad8
- quay.io/bar/logger:master-d9500ad8

default:deployment/moo
- quay.io/bar/nginx:master-d9500ad8
```
@rndstr rndstr force-pushed the issue/1478-release-containers-commit-message branch from 97da053 to 2a418fe Compare October 30, 2018 00:25
@rndstr rndstr requested a review from squaremo October 30, 2018 00:25
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Roli 🍍

@squaremo squaremo merged commit 166a08a into master Oct 30, 2018
@rndstr rndstr deleted the issue/1478-release-containers-commit-message branch October 31, 2018 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants