Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Updates list of exposed metrics #1483

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Conversation

Ashiroq
Copy link
Contributor

@Ashiroq Ashiroq commented Oct 31, 2018

Closes #1458
Not entirely sure if this is correct.

@hiddeco hiddeco added the docs Issue or PR relates to documentation label Oct 31, 2018
@hiddeco
Copy link
Member

hiddeco commented Oct 31, 2018

Thanks a lot for your contribution! 🏅

It is a great start but I think it would be even better if we would make it a table in the following format:

| metric                                | description                             |
|---------------------------------------|-----------------------------------------|
| `flux_cache_request_duration_seconds` | Duration of cache requests, in seconds. |

This way a user not only has a description of what is exposed but also knows how it is exposed.

Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Ashiroq and thanks for the review @hiddeco!

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks @Ashiroq

@hiddeco hiddeco merged commit aea9dce into fluxcd:master Nov 1, 2018
@Ashiroq Ashiroq deleted the docs-monitoring branch November 2, 2018 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants