This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Include proxy env variables in git operations if set #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the allowed env variables are only those required by git to work behind a HTTP(S) proxy (`HTTP_PROXY, `HTTPS_PROXY and `NO_PROXY`). Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
1535-http-proxy
branch
from
b9f2e5b
to
eb371a2
Compare
stefanprodan
approved these changes
Nov 28, 2018
rade
reviewed
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535.
Includes proxy env variables (
http_proxy,https_proxyandno_proxy) in Git operations if they are set.