This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Warn users about external changes in sync tag #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple users have reported an unexpectedly high number of changes in the git respository's sync tag. This has been attributed to multiple fluxd instances, running in separate clusters, using the same git repository and sync tag. In addition, multiple fluxd instances using the same tag is a bad idea in general, since it will lead to commits being missed by fluxd. This change tracks the value of the sync tag and prints a warning when detecting an external change.
|
Failing CI because doSync is called in some tests, apparently |
|
Ah, Will fix ASAP and merge.
…On Thu, Jan 31, 2019, 15:42 Michael Bridgen ***@***.*** wrote:
Failing CI because doSync is called in some tests, apparently
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1695 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACQOJB3TcMp8RCP7X2f-yr5efAb6XOdoks5vIwC5gaJpZM4aaeeZ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple users have reported an unexpectedly high number of changes in the git
respository's sync tag.
This has been attributed to multiple fluxd instances, running in separate
clusters, using the same git repository and sync tag.
In addition, multiple fluxd instances using the same tag is a bad idea in
general, since it will lead to commits being missed by fluxd.
This change tracks the value of the sync tag and prints a warning when detecting
an external change.