Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Updates Docs (wording, typos, formatting) #1753

Merged
merged 22 commits into from
Feb 21, 2019

Conversation

dimitropoulos
Copy link
Contributor

I did a thorough once-over on all of the documentation I could find and made a few minor changes I saw along the way. I made the changes in atomic commits so that (A) the rationale for the individual change is always clear and (B) individual changes can easily be rejected.

otherwise you'd get something like:
```
error: the server doesn't have a resource type "default-values"
```
the author clearly intended this to break onto two lines, but markdown does not respect linebreaks in this context without an addtional line between
@2opremio
Copy link
Contributor

This is awesome, thanks!

@@ -188,13 +176,24 @@ Using an SSH key allows you to maintain control of the repository. You
can revoke permission for `flux` to access the repository at any time
by removing the deploy key.

```sh
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to rethink about including this output in the docs (or automate it?) as it is likely to change over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same thing. In the past I have used https://github.com/danger/danger which basically would allow us to write code that enforces that when the help text changes that the documentation will/should also change. That's the best option I know of (and, there are ways in which it isn't great) that meets the minimum requirement of curbing some of that stuff getting out of date.

Another option would be to just have a quarterly health-and-wellness checkup list that would include updating documentation of this sort. Just an idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's file a separate issue about this?

Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dimitropoulos! Thanks for the docs review!

@@ -188,13 +176,24 @@ Using an SSH key allows you to maintain control of the repository. You
can revoke permission for `flux` to access the repository at any time
by removing the deploy key.

```sh
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's file a separate issue about this?

@dholbach dholbach added the docs Issue or PR relates to documentation label Feb 21, 2019
@dimitropoulos dimitropoulos merged commit c2dfbf5 into fluxcd:master Feb 21, 2019
@dimitropoulos dimitropoulos deleted the updates-docs branch February 21, 2019 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants