This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Improve testing in local environments other than linux-amd64 #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests rely on the `helm` binary and assume that the executing environment is `linux-amd64`. This makes tests fail in other environments like `darwin`, making development unpleasant. This change improves the situation by downloading and running test-specific binaries from the local OS/architecture. Apart from running the `helm` binary this change also downloads `kubectl` in preparation for testing the parsing of `kubectl config current-context` in fluxcd#1442 .
11 tasks
hiddeco
approved these changes
Feb 26, 2019
|
@2opremio having checked out to a different branch: |
|
Thanks for the review!
Good one, will fix |
hiddeco
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests rely on the
helmbinary and assume that the executing environmentis
linux-amd64.This makes tests fail in other environments like
darwin, making developmentunpleasant.
This change improves the situation by downloading and running test-specific
binaries from the local OS/architecture.
Apart from running the
helmbinary this change also downloadskubectlinpreparation for testing the parsing of
kubectl config current-contextin#1442 .