This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Require creation metadata during auto release #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice -- less code, and better safeguard. Can we have a test case, please? |
In the following circumstances: * A registry experiences a fault where it fails to enumerate all tags when asked without signalling an error condition * The tag for an image in an automated workload is not returned by the registry API * Older image tags are returned Flux would roll back the image to an older version, because it couldn't tell the current image is newer. Instead, Flux now refuses to automate unless it has timestamp information for the current and new version, as this assures the made comparison is valid.
hiddeco
force-pushed
the
1817-require-image-metadata
branch
from
2bc805b
to
be64435
Compare
squaremo
reviewed
Mar 18, 2019
hiddeco
commented
Mar 18, 2019
hiddeco
force-pushed
the
1817-require-image-metadata
branch
from
0c30068
to
060b092
Compare
squaremo
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1817
In the following circumstances:
tags when asked without signalling an error condition
by the registry API
Flux would roll back the image to an older version, because it
couldn't tell the current image is newer. Instead, Flux now refuses
to automate unless it has timestamp information for the current and
new version, as this assures the made comparison is valid.