This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Obtain scope of CRD instances from its manifest as a fallback #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squaremo
reviewed
Mar 28, 2019
2opremio
force-pushed
the
1825-fix-creating-crd-and-instances
branch
5 times, most recently
from
73550eb
to
b20944d
Compare
Before this, we were only obtaining the scope of CRD instances from the cluster. However, this wasn't good enough if the Git repository contained both the CRD manifest and instance manifests.
2opremio
force-pushed
the
1825-fix-creating-crd-and-instances
branch
from
b20944d
to
ceac801
Compare
|
I case you are wondering about the last commit amendment, I just renamed |
|
K |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, we were only obtaining the scope of CRD instances from the cluster.
However, this wasn't good enough if the Git repository contained both the CRD manifest and instance manifests.
Fixes #1825