This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix tag_all pseudo policy on default-namespaced wokloads
#1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced by fluxcd#1442 in which applying the `tag_all` pseudo policy failed for workload manifests in which the namespace is omitted. The effective namespace of the workload wasn't set after parsing, causing a mismatch in the resource identifier (the parsed resource identifier was cluster-scoped due to the lack of explicit namespace in the manifest).
2opremio
commented
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #1442 in which applying the
tag_allpseudo policy failed for workload manifests in which the namespace is omitted.The effective namespace of the workload wasn't set after parsing, causing a mismatch in the resource identifier (the parsed resource identifier was cluster-scoped due to the lack of explicit namespace in the manifest).