This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Split Warmer.warm() into smaller functions #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
refactor-warmer
branch
from
0983841
to
c92865c
Compare
2opremio
changed the title
2opremio
force-pushed
the
refactor-warmer
branch
3 times, most recently
from
fe1d18a
to
dcd3fb3
Compare
`Warmer.warming()` was a huge function (~250 loc), making it really hard to read. This change moves most of it into a new `repoCacheManager`, improving readability. After this change `Warmer.warming()` is still 100 loc, but reads much better.
2opremio
force-pushed
the
refactor-warmer
branch
from
dcd3fb3
to
fefb216
Compare
2opremio
changed the title
hiddeco
reviewed
Apr 15, 2019
hiddeco
reviewed
Apr 15, 2019
| // updateImages, refreshes the cache entries for the images passed. It may not succeed for all images. | ||
| // It returns the values stored in cache, the number of images it succeeded for and the number | ||
| // of images whose manifest wasn't found in the registry. | ||
| func (c *repoCacheManager) updateImages(ctx context.Context, registryClient registry.Client, images []imageToUpdate) (map[string]image.Info, int, int) { |
There was a problem hiding this comment.
Just a note; I am not a fan of the .., int, int return, but wrapping it in a struct to give it more context does not seem very meaningful either, the comment makes up for it a bit though.
There was a problem hiding this comment.
Yeah, I am not too pleased with this or fetchImagesResult either
Happy to look into any suggestions you may have.
Maybe computing the counters outside of the functions? I gave that a short chance but it was hairy. I will give it another try.
There was a problem hiding this comment.
I didn't find a cleaner way. At least not with a much bigger refactoring.
hiddeco
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warmer.warming()was a huge function (~250 loc), making it really hard to read.This change splits the warmer into smaller functions, improving readability.
After this change
Warmer.warming()is still 100 loc, but reads much better.