This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Warn user about non-existing configured branch #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user tried to configure Flux against an empty repository or a branch that did not exist we would report a bogus status and left the user confused. This commit makes it possible to configure a branch that should be checked for existence on creation of a new repository. In case there is no HEAD found for this branch, it does not exist in git terms, and we report back a meaningful error message to the user. As a bonus we also use this configured branch when we create a tag for our write check, so we do not touch anything the user has not told us to.
hiddeco
force-pushed
the
bug/904-empty-repo
branch
from
bda15d7 to
9d6355f
Compare
2opremio
approved these changes
Apr 15, 2019
|
Thanks! |
stefanprodan
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user tried to configure Flux against an empty repository or a
branch that did not exist we would report a bogus status and left the
user confused.
This commit makes it possible to configure a branch that should be
checked for existence on creation of a new repository. In case there
is no HEAD found for this branch, it does not exist in git terms, and
we report back a meaningful error message to the user.
As a bonus we also use this configured branch when we create a tag for
our write check, so we do not touch anything the user has not told us
to.
Fixes #904, bonus fixes #1885