This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Exclude resources if we cannot find their scope #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
commented
Apr 16, 2019
2opremio
force-pushed
the
1941-fix-CRD-syncing
branch
2 times, most recently
from
e144eb8 to
17cee20
Compare
hiddeco
approved these changes
Apr 16, 2019
This is aiming at custom resources whose scope is unknown because its CRD is included in a helm chart Flux won't inspect (since it's the helm operator's responsibility to do it). This allows Flux to move forward and create the `HelmRelease` supplying the CRD. In a subsequent sync, once we know its scope, the custom resources will be created.
2opremio
force-pushed
the
1941-fix-CRD-syncing
branch
from
17cee20 to
6f2eba2
Compare
Yeah, I think we do. @brantb Before we merge, can you test this image to double-check the problem is gone for you? |
|
Heheh, great |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
This is aiming at custom resources whose scope is unknown because its CRD is included in a helm chart Flux won't inspect (since it's the helm operator's responsibility to do it).
This allows Flux to move forward and create the
HelmReleasesupplying the CRD. In a subsequent sync, once we know its scope, the custom resources will be created.I was on the fence on whether I should revert #1876 but I decided against it, since it's not a lot of code (mostly reusable test-code) and it's less confusing for the user to obtain the custom resource scope locally if we have it.