This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Always list the status of a workload in fluxctl
#2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
show-release-status-hr
branch
from
9d1bc45
to
05d60ce
Compare
Before this change the `fluxctl list-workloads` command would only list the status of a workload if it had containers. But because of how we integrated HelmReleases into the Flux daemon, a HelmRelease only has 'containers' if we are able to detect images in the .spec.values of the resource. After this change it will always list the status of the workload (and any policies), regardless of the amount of containers it (does not) have.
hiddeco
force-pushed
the
show-release-status-hr
branch
from
05d60ce
to
734021a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the
fluxctl list-workloadscommand would only list the status of a workload if it had containers. But because of how we integrated HelmReleases into the Flux daemon, a HelmRelease only has 'containers' if we are able to detect images in the .spec.values of the resource.After this change it will always list the status of the workload (and any policies), regardless of the amount of containers it (does not) have.