This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Use the exact credentials collected for the image domain #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamarakaufler
approved these changes
Jan 12, 2018
samb1729
reviewed
Jan 15, 2018
registry/credentials.go
Outdated
| } | ||
|
|
||
| func (c creds) String() string { | ||
| if c.username == "" && c.password == "" && c.registry == "" && c.provenance == "" { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
It's possible to be looking up an image at index.docker.io and be told to authorise with auth.docker.io. In this case, the registry fetch currently fails, because it has been supplied with credentials for index.docker.io, and is asked for credentials for auth.docker.io. Since, at the time, we're fetching a particular image and the credentials are associated with the image's domain, this is a failure of logic. We should use the exact credentials collected for the image's domain. I've added a bit more logging such that when --registry-trace is on, the nature and provenance of the credentials will be shown.
squaremo
force-pushed
the
issue/896-docker-reg-auth
branch
from
43d6fcd
to
3133fa9
Compare
|
Thanks @tamarakaufler and @Sambooo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896.