Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Missing validation functions #301

Open
4 tasks
twelho opened this issue Aug 8, 2019 · 5 comments
Open
4 tasks

Missing validation functions #301

twelho opened this issue Aug 8, 2019 · 5 comments
Labels
good first issue Good for newcomers kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@twelho
Copy link
Contributor

twelho commented Aug 8, 2019

All missing validation functions are tracked here. If you find some validation missing, add it to this list or comment on this issue.

  • VM CPUs
  • VM memory
  • VM disk max/min sizes
  • VM port mappings
@twelho twelho added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Aug 8, 2019
@luxas
Copy link
Contributor

luxas commented Aug 9, 2019

Adding that network mode CNI and VM portmappings are mutually exclusive.

@luxas luxas added this to the Next milestone Aug 9, 2019
@twelho twelho added the good first issue Good for newcomers label Aug 27, 2019
@twelho
Copy link
Contributor Author

twelho commented Aug 30, 2019

CNI now supports port mappings, so removing the mutual exclusitivity requirement.

@anirudh-goyal
Copy link

Hello, I am a student from the University of Texas at Austin. I wanted to know if a group of my colleagues and I could work on this issue as part of an assignment for our virtualization class. Thank you!

(We don't have experience with virtualization so we chose an issue with the label good first issue)

@stealthybox
Copy link
Contributor

Hi @anirudh-goyal, we would welcome your contributions

This is definitely an approachable issue.
It's related to the api's we use to describe VM's

The code that needs to change starts here:
https://github.com/weaveworks/ignite/blob/9c9c4db/pkg/apis/ignite/validation/validation.go#L21-L22

Also, feel free to join our development calls on Monday.

@jeffreyxie0615
Copy link

Hi! Is this issue still open to be worked on? My partner and I are students from UT Austin, and we were wondering if we could tackle this as a good first issue for our virtualization class?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants