Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Redesign the image and kernel ociClaim #309

Closed
luxas opened this issue Aug 9, 2019 · 1 comment · Fixed by #311
Closed

Redesign the image and kernel ociClaim #309

luxas opened this issue Aug 9, 2019 · 1 comment · Fixed by #311
Assignees
Labels
api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Aug 9, 2019

As per #298; we're gonna simplify

spec:
  image:
    ociClaim:
      ref: weaveworks/ignite-ubuntu:latest
      type: Docker

to

spec:
  image:
    # Any image that is following the OCI specification is valid here.
    ociRef: weaveworks/ignite-ubuntu:latest
    # Reserve the possibility to add fields for other details

(and the same for kernel)

@luxas luxas added api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 9, 2019
@luxas luxas added this to the v1alpha2 milestone Aug 9, 2019
@twelho
Copy link
Contributor

twelho commented Aug 9, 2019

After some additional thought, we're going to further shorten ociRef to just oci, it's enough to signal the resource should be retrieved from the OCI implementation. So the target design looks like this:

spec:
  image:
    # Any image that is following the OCI specification is valid here.
    oci: weaveworks/ignite-ubuntu:latest
    # Reserve the possibility to add fields for other details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants