Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove v1alpha1 in v0.8.0 #355

Closed
luxas opened this issue Aug 19, 2019 · 5 comments · Fixed by #620
Closed

Remove v1alpha1 in v0.8.0 #355

luxas opened this issue Aug 19, 2019 · 5 comments · Fixed by #620
Assignees
@darkowlzz
Labels
kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.7.0

Comments

@luxas
Copy link
Contributor

luxas commented Aug 19, 2019 •
edited by twelho
Loading

We will support upgrades so that you can seamlessly go one minor version up at any time without breaking, but we won't hold an old API version left in the binary more releases than necessary.

Upgrading from v1alpha1 (the only option in v0.4.0) to v1alpha2 was possible in v0.5.0, but is not needed in v0.6.0 anymore as everything touched by v0.5.0 is always at v1alpha2.

Update: We'll remove v1alpha1 from v0.7.0, as that most likely introduces v1alpha3. Maintaining three API versions in parallel would take up too much time/effort. v0.6.0 will thus have v1alpha1 still available (use discouraged).
@luxas luxas added this to the v0.6.0 milestone Aug 19, 2019
@luxas luxas added kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 19, 2019
@luxas luxas modified the milestones: v0.6.0, v0.7.0 Aug 30, 2019
@twelho twelho changed the title Remove v1alpha1 in v0.6.0 Remove v1alpha1 in v0.7.0 Aug 30, 2019
@luxas
Copy link
Contributor Author

luxas commented Sep 1, 2019

@chanwit

@chanwit
Copy link
Member

chanwit commented Sep 1, 2019

got it!

@luxas luxas changed the title Remove v1alpha1 in v0.7.0 Remove v1alpha1 in v0.8.0 Jun 11, 2020
@luxas
Copy link
Contributor Author

luxas commented Jun 11, 2020

@darkowlzz could you please do this? when this is done, we can create a new v1alpha3, to which you can add the Config object, ref: #601

@luxas luxas mentioned this issue Jun 11, 2020
Merged
@darkowlzz
Copy link
Contributor

@luxas sure. Is it just removing the package pkg/apis/ignite/v1alpha1 and updating any code that uses it to v1alpha2?

@luxas
Copy link
Contributor Author

luxas commented Jun 11, 2020

Yes. After that we can duplicate v1alpha2 into v1alpha3, and then start modifying v1alpha3 to have the new things we want.

This was referenced Jun 15, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkowlzz darkowlzz

Labels
kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Remove ignite v1alpha1 API darkowlzz/ignite
3 participants
@chanwit @darkowlzz @luxas