Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Not able to run make build-all #383

Closed
karanparhar opened this issue Aug 31, 2019 · 11 comments · Fixed by #389
Closed

Not able to run make build-all #383

karanparhar opened this issue Aug 31, 2019 · 11 comments · Fixed by #389

Comments

@karanparhar
Copy link

Error : Makefile:20: *** missing separator. Stop

@chanwit
Copy link
Member

chanwit commented Aug 31, 2019

from which branch you're building?

if from the master (and v0.6.0), it's just working fine to me.

@karanparhar
Copy link
Author

I'm building from master (and v0.6.0)

@chanwit
Copy link
Member

chanwit commented Sep 1, 2019

It might be relating to tab characters in Makefile getting changed or replaced.
Did you modify the Makefile?

@silenceshell
Copy link
Contributor

I have met this problem on macOS, for my make is GNU Make 3.81, which does not support undefine.

To avoid this, just delete the line 20, or upgrade your make above version 3.82.

undefine GOFLAGS

@chanwit
Copy link
Member

chanwit commented Sep 2, 2019

that surprised me! Thank you @silenceshell .
I'm using Linux so I haven't noticed that a different version of make on macOS would cause a problem to @karanparhar .

@chanwit
Copy link
Member

chanwit commented Sep 2, 2019

To help confirm this, my make version is 4.and I don't have the problem withundefine`.

@chanwit
Copy link
Member

chanwit commented Sep 2, 2019

noted that we need to specify the minimum version of make somewhere in the build doc.

@silenceshell
Copy link
Contributor

@chanwit I agree and would like to submit a PR to fix the doc :)

@karanparhar
Copy link
Author

@chanwit After updating the make version i'm able to build

@chanwit
Copy link
Member

chanwit commented Sep 3, 2019

@silenceshell sure please do.

@chanwit
Copy link
Member

chanwit commented Sep 3, 2019

@karanparhar great to hear that it's working for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants