prometheus socket left open after ignited gitops terminates

[palemtnrider]

While running ignited gitops a prometheus socket is opened but not closed on termination. This causes errors on subsequent runs if the user doesn't remove the /var/lib/firecracker/daemon.sock file.

Ignite version: version.Info{Major:"0", Minor:"6+", GitVersion:"v0.6.0-106+0a90cfbced8163-dirty", GitCommit:"0a90cfbced8163507831f885d3eef343e20f0875", GitTreeState:"dirty", BuildDate:"2019-11-04T04:05:01Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Firecracker version: v0.18.0
Runtime: containerd

[bbros-dev]

@chanwit and @palemtnrider I'm still seeing this behavior:

System vagrant@service-ubuntu-1804

$ sudo ignited version
Ignite version: version.Info{Major:"0", Minor:"6", GitVersion:"v0.6.3", GitCommit:"ed51b9378f6e0982461074734beb145d571d56a6", GitTreeState:"clean", 
BuildDate:"2019-12-10T06:20:00Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Firecracker version: v0.18.1
Runtime: containerd

$ sudo ignited daemon
INFO[0000] Starting reconciliation loop... 
^CClosing...
$ sudo ignited daemon
INFO[0000] Starting reconciliation loop...              
ERRO[0000] prometheus server was stopped with error: listen unix /var/lib/firecracker/daemon.sock: bind: address already in use 
^CClosing...

[chanwit]

Acked. Thank you @bbros-dev for reporting!

[bbros-dev]

Can you please re-open this so status can be tracked?

[bbros-dev]

bump @chanwit - is there a reason this shouldn't be reopened?