Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

StartVM hardcoded to weavworks/ignite:<tag> #566

Closed
alex-leonhardt opened this issue Mar 23, 2020 · 1 comment
Closed

StartVM hardcoded to weavworks/ignite:<tag> #566

alex-leonhardt opened this issue Mar 23, 2020 · 1 comment
Labels
area/runtime Issues related to container runtimes
Milestone

Comments

@alex-leonhardt
Copy link

Hi,

I tried to manually build ignite and that worked just fine, however, when trying to run the new binary (on a different host), it attempted to download a weaveworks/ignite image that won't exist .. I tracked it down to this: https://github.com/weaveworks/ignite/blob/master/pkg/operations/start.go#L41

Would it be feasible to allow this to use the DOCKER_USER from the Makefile https://github.com/weaveworks/ignite/blob/master/Makefile#L35 ?

So that it would not attempt to use a weaveworks/ignite:<does-not-exist> container when spinning up the VM ?

Thanks
Alex

@stealthybox
Copy link
Contributor

Hi @alex-leonhardt, this is now configurable at runtime via flags and VM API Spec configs.

Fixed by #598 released in v0.7.0

@stealthybox stealthybox added this to the v0.7.0 milestone Jun 23, 2020
@stealthybox stealthybox added the area/runtime Issues related to container runtimes label Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/runtime Issues related to container runtimes
Projects
None yet
Development

No branches or pull requests

2 participants