Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Use github.com/vishvananda/netlink instead of execing to ip #85

Closed
luxas opened this issue Jul 1, 2019 · 2 comments · Fixed by #279
Closed

Use github.com/vishvananda/netlink instead of execing to ip #85

luxas opened this issue Jul 1, 2019 · 2 comments · Fixed by #279
Labels
contributor-assigned This issue has been assigned to a contributor help wanted Extra attention is needed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.5.0

Comments

@luxas
Copy link
Contributor

luxas commented Jul 1, 2019

https://github.com/vishvananda/netlink is the de-facto Go package to use for manipulating network interfaces.
@luxas luxas added this to the v0.5.0 milestone Jul 1, 2019
@luxas luxas mentioned this issue Jul 12, 2019
Merged
@luxas luxas added help wanted Extra attention is needed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 17, 2019
@luxas
Copy link
Contributor Author

luxas commented Jul 17, 2019

The relevant code which should be converted to use https://github.com/vishvananda/netlink instead of execing to ip is here: https://github.com/weaveworks/ignite/blob/master/pkg/container/network.go

Help from the community here would be super-appreciated!

@luxas
Copy link
Contributor Author

luxas commented Aug 2, 2019

Moving this out of v0.5.0; we won't have time for this before releasing v0.5.0.

@luxas luxas modified the milestones: v0.5.0, Next Aug 2, 2019
@alexeldeib alexeldeib mentioned this issue Aug 6, 2019
Merged
@luxas luxas added the contributor-assigned This issue has been assigned to a contributor label Aug 6, 2019
@luxas luxas modified the milestones: Next, v0.5.0 Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributor-assigned This issue has been assigned to a contributor help wanted Extra attention is needed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Refactor: Use the netlink library instead of exec'ing out to ip alexeldeib/ignite
1 participant
@luxas