This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Allow provider override when using config file #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ignite configuration file, the global flags --runtime and --network-plugin were ignored. This enables the overrides to work. The default runtime and network-plugin name assignment is moved from providers into NewIgniteCommand and the defaults are set only when the values are empty after applying config files and flag overrides.
darkowlzz
force-pushed
the
config-provisioner-override
branch
from
33a33f3
to
c49e317
Compare
|
Writing a test for this will be easier if we have runtime and network-plugin info in the VM object. |
darkowlzz
added
documentation/improvement
darkowlzz
changed the title
stealthybox
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ignite configuration file, the global flags
--runtimeand--network-pluginwere ignored. This change enables the overrides to work.The default runtime and network-plugin name assignment is moved from
providers into
NewIgniteCommandand the defaults are set only when thevalues are empty after applying config files and flag overrides.