Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for slack/prometheus behaviour #243

Open
evrardjp opened this issue Nov 27, 2020 · 3 comments
Open

Add unit tests for slack/prometheus behaviour #243

evrardjp opened this issue Nov 27, 2020 · 3 comments
Labels
keep This won't be closed by the stale bot. testing

Comments

@evrardjp
Copy link
Collaborator

evrardjp commented Nov 27, 2020

As our automated (in github actions) release testing only does pure functional testing, we might miss some of the extra features kured is providing, like messaging notifications or prometheus integration.

To avoid issues creeping in into the release, we should probably test those integrations into each PR.
By testing those into PRs, we can also safely bump dependabot updates. (This could technically allow an auto-merge of dependabot dependencies in the future, as long as they are not client-go/kubectl related).

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@ckotzbauer ckotzbauer added keep This won't be closed by the stale bot. and removed no-issue-activity labels Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep This won't be closed by the stale bot. testing
Projects
None yet
Development

No branches or pull requests

3 participants