Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a pipe fails on first attempt #1095

Closed
errordeveloper opened this issue Mar 2, 2016 · 5 comments
Closed

Opening a pipe fails on first attempt #1095

errordeveloper opened this issue Mar 2, 2016 · 5 comments

Comments

@errordeveloper
Copy link
Contributor

screenshot 2016-03-02 15 41 30

screenshot 2016-03-02 15 42 00

@errordeveloper
Copy link
Contributor Author

@tomwilkie said it's by design, but should be 404 instead of 400...

@foot
Copy link
Contributor

foot commented Mar 2, 2016

It is by design :).

404: pipe doesn't exist, request a new one.
400: pipe exists! why are you connecting to a websocket endpoint w/ a xhr GET? that is a very invalid thing to do here is a 400 for your troubles.

So we might be able to "fix" this in the client by checking if a pipe exists w/ a WS connection instead, I forget if we tried to do that in the past and it didn't work for some reason... Or the server could add a new endpoint that is not a WS that returns a 200 if a pipe exists.

@foot
Copy link
Contributor

foot commented Mar 2, 2016

I will try in the client first.

@foot foot self-assigned this Mar 2, 2016
@foot
Copy link
Contributor

foot commented Mar 2, 2016

Oh yeah you can't read the http response code from a WS for browser security reasons.

Earlier discussions #650 (comment)

We'd need a new server endpoint.

@foot foot removed their assignment Mar 2, 2016
@tomwilkie
Copy link
Contributor

Dupe of #994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants