Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irrelevant views clutter the UI #1364

Closed
rade opened this issue Apr 21, 2016 · 9 comments
Closed

irrelevant views clutter the UI #1364

rade opened this issue Apr 21, 2016 · 9 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer k8s Pertains to integration with Kubernetes
Milestone

Comments

@rade
Copy link
Member

rade commented Apr 21, 2016

If I am not running k8s, I have no use for the 'Pods' view, or any other k8s views we are contemplating. They just become a distraction and might even confuse users who know nothing about k8s.

The same applies to any other platform-specific views we might add.

Suggestion: we should be able to detect fairly accurately whether we have any k8s/etc in a report, and limit the views we show accordingly.

@rade rade added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Apr 21, 2016
@paulbellamy
Copy link
Contributor

paulbellamy commented Apr 21, 2016

The kubernetes view are only shown if k8s is detected by the probe.

@paulbellamy paulbellamy added the bug Broken end user or developer functionality; not working as the developers intended it label Apr 21, 2016
@rade
Copy link
Member Author

rade commented Apr 21, 2016

The kubernetes view are only shown if k8s is detected by the probe.

Since when? I always see 'Pods - By Service', even in the current master, and I sure am not running k8s.

@tomwilkie
Copy link
Contributor

What version are you running @rade?

We did a bunch of work to make what paul said the case, we might have missed something.

Please include a report.

@tomwilkie tomwilkie added the k8s Pertains to integration with Kubernetes label Apr 21, 2016
@paulbellamy
Copy link
Contributor

screen shot 2016-04-21 at 14 50 28

@tomwilkie
Copy link
Contributor

Hmpf. Thats post 0.14 at least.

@rade
Copy link
Member Author

rade commented Apr 21, 2016

Hmpf. Thats post 0.14 at least.

I said I was running current master!

@tomwilkie tomwilkie added this to the 0.15.0 milestone Apr 21, 2016
@tomwilkie
Copy link
Contributor

@paulbellamy I think I might propagate a kubernetes flag in the report in kubernetes is enabled, and filter all nodes from the view if this flag is not set. Thoughts?

@paulbellamy
Copy link
Contributor

I'm a bit puzzled why FilterEmpty(report.Pod, ...) Isn't removing the managed node, maybe we need to do a FilterUnconnectedPseudo on it?

@tomwilkie
Copy link
Contributor

I'm a bit puzzled why FilterEmpty(report.Pod, ...) Isn't removing the managed node, maybe we need to do a FilterUnconnectedPseudo on it?

The unmanaged nodes is connected to itself in this instance, so therefore is not unconnected.

But in general it could be pointing to the internet (or the internet pointing at it) so I don't think its enough to rely on hiding the view if there are no nodes - hence the idea to propagate the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer k8s Pertains to integration with Kubernetes
Projects
None yet
Development

No branches or pull requests

3 participants