Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement contrast mode #2363

Closed
jpellizzari opened this issue Mar 21, 2017 · 1 comment
Closed

Re-implement contrast mode #2363

jpellizzari opened this issue Mar 21, 2017 · 1 comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/days It will take between 2 and 7 8-hour work days to implement good-first-issue Indicates a good issue for first-time contributors help-wanted An issue that would be good for non-maintainers to attempt

Comments

@jpellizzari
Copy link
Contributor

Currently, Scope relies on loading a second stylesheet with overridden Sass variables to show a high-contrast mode. This works well for stand-alone, but it difficult to deal with when running as a component.

Instead of a second stylesheet, we should create a wrapper CSS class with the necessary style overrides. Then, to enable contrast mode, we switch the class that is applied to the Scope root DOM element. This is generally how 'theme-ing' is implemented.

Benefits:

  • Less webpack shenanigans
  • Theme switches immediately (no network call needed)
@jpellizzari jpellizzari added chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Mar 21, 2017
@2opremio 2opremio added the good-first-issue Indicates a good issue for first-time contributors label Jun 4, 2018
@fbarl fbarl added hacktoberfest 2018 estimate/days It will take between 2 and 7 8-hour work days to implement labels Sep 26, 2018
@satyamz satyamz added help-wanted An issue that would be good for non-maintainers to attempt and removed hacktoberfest labels Nov 16, 2018
@fbarl
Copy link
Contributor

fbarl commented May 22, 2019

This was resolved in #3580.

@fbarl fbarl closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/days It will take between 2 and 7 8-hour work days to implement good-first-issue Indicates a good issue for first-time contributors help-wanted An issue that would be good for non-maintainers to attempt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fbarl @2opremio @jpellizzari @satyamz