Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 16.5 and perhaps other libraries too. #3350

Closed
foot opened this issue Sep 17, 2018 · 1 comment
Closed

Upgrade to React 16.5 and perhaps other libraries too. #3350

foot opened this issue Sep 17, 2018 · 1 comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/hours It will take less than 8 hours to implement tech-debt Unpleasantness that does (or may in future) affect development

Comments

@foot
Copy link
Contributor

foot commented Sep 17, 2018

https://github.com/weaveworks/ui-components has been upgraded to 16.5 which widens the gap between it and scope to 16.5 - 16.1 = 0.4!!! React should stay backwards compatible but new API's have been added to 16.3 e.g. getDerivedStateFromProps which might end up getting used and causing issues.
@foot foot added tech-debt Unpleasantness that does (or may in future) affect development component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality estimate/hours It will take less than 8 hours to implement labels Sep 17, 2018
@foot
Copy link
Contributor Author

foot commented Nov 15, 2018

Thanks @filip!

Fixes in #3431

@foot foot closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/hours It will take less than 8 hours to implement tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@foot