Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet should not count as a stopped container #665

Closed
paulbellamy opened this issue Nov 13, 2015 · 2 comments
Closed

Internet should not count as a stopped container #665

paulbellamy opened this issue Nov 13, 2015 · 2 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it

Comments

@paulbellamy
Copy link
Contributor

report.json: https://gist.github.com/paulbellamy/3728756331b3e781f6ef

@paulbellamy paulbellamy added the bug Broken end user or developer functionality; not working as the developers intended it label Nov 13, 2015
@tomwilkie tomwilkie self-assigned this Nov 13, 2015
@tomwilkie
Copy link
Contributor

The bigger question is why is there an unconnected internet node? It looks like that node exists due to an old connection to an old container. Its similar to the unconnected uncontained node, see in #511.

@tomwilkie
Copy link
Contributor

There is a baked in assumption that pseudo nodes cannot exist unless they are connected to something. The filter code assumes this, so assumes any unconnected pseudo nodes are newly unconnected by the filtering process, and removes them. I think this is still correct.

The fix therefore is to ensure unconnected pseudo nodes don't make it into the topology to begin with. This can happen a bunch of ways, in particular is a container does short lived connections to the internet from the host net ns - the short lived connection code cannot attribute them, as they share an IP.

Anyway, fix is to filter out unconnected nodes from the short-lived-connection logic before merging with the final view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

2 participants