Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

pointless slice pointers #48

Open
rade opened this issue Jul 12, 2017 · 0 comments
Open

pointless slice pointers #48

rade opened this issue Jul 12, 2017 · 0 comments

Comments

@rade
Copy link
Member

rade commented Jul 12, 2017

The functions in event.go take slice pointer arguments, e.g. data *[]byte, instead of simply slices. That is pointless (pun intended) and non-idiomatic go.

Fixing this entails changing iovisor/gobpf, since the timestamp function signatures need to match the ones there.

cc @alban

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant