Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce theme border radius #208

Closed
fbarl opened this issue May 11, 2018 · 0 comments
Closed

Enforce theme border radius #208

fbarl opened this issue May 11, 2018 · 0 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system

Comments

@fbarl
Copy link
Contributor

fbarl commented May 11, 2018

We have different values appearing across our code, including 2px, 3px, 4px, 5px, 8px, 10px and 50%, but I think the only values we really need before enforcing the theme are 0, 4px (the current one) and 50%, e.g.:

borderRadius.none: 0
borderRadius.soft: 4px
borderRadius.round: 50%

The cases like border-radius: 0 4px 4px 0; could then be split into two lines:

border-top-right-radius: ${props => props.theme.borderRadius.soft};
border-bottom-right-radius: ${props => props.theme.borderRadius.soft};

cc @bia @jpellizzari

@fbarl fbarl added chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system labels May 11, 2018
@fbarl fbarl self-assigned this May 11, 2018
@fbarl fbarl closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system
Projects
None yet
Development

No branches or pull requests

1 participant