Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on react-router #487

Open
foot opened this issue Sep 6, 2019 · 1 comment
Open

Remove dependence on react-router #487

foot opened this issue Sep 6, 2019 · 1 comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality

Comments

@foot
Copy link
Contributor

foot commented Sep 6, 2019

It is used for just the <Link /> cmp..

src/components/ResourceDial/ResourceDial.js
3:import { Link } from 'react-router';

src/components/_DeploymentAnnotation/DeploymentAnnotation.js
4:import { Link } from 'react-router';
@fbarl
Copy link
Contributor

fbarl commented Sep 14, 2019

Related to #482.

Looking at these issues, we should probably replace all relative links with absolute href-type URLs, that should address both of them.

@fbarl fbarl added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality
Projects
None yet
Development

No branches or pull requests

2 participants