Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter dialog + chips do not display anything for undefined values #2712

Closed
joshri opened this issue Sep 6, 2022 · 0 comments · Fixed by #2714
Closed

Filter dialog + chips do not display anything for undefined values #2712

joshri opened this issue Sep 6, 2022 · 0 comments · Fixed by #2714
Assignees
Labels
bug Something isn't working

Comments

@joshri
Copy link
Contributor

joshri commented Sep 6, 2022

Filtering wasn't implemented with undefined values in mind. It........looks like it works? The problem is in the actual display, where you get nothing after the : in the chip, and nothing after the checkbox in the dialog. Fixing this quickly spirals into potentially rebuilding filtering from the ground up, as it uses these string values to accurately filter the data. It's all very integrated and not easily customizable. Existing work on this is living in the branch filter-undefined

image

Environment

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant