Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-column text search #2724

Closed
joshri opened this issue Sep 12, 2022 · 1 comment
Closed

Multi-column text search #2724

joshri opened this issue Sep 12, 2022 · 1 comment
Labels
area/ui Issues that require front-end work priority_low Items we want to complete in the next >= 90 days team/wild-watermelon type/enhancement New feature or request type/story

Comments

@joshri
Copy link
Contributor

joshri commented Sep 12, 2022

Short description
Users should be able to text search on multiple columns - here's @ozamosi in #2714 :

"...The text filters seem like they should be ANDed based on the tests, so I'm going to assume that's correct.

To make this work properly, I think we need to:

First (inner-most) OR each field together - any field that matches a single text filter means that the whole row matches that filter.
Then, AND the filters together.
And only then do we decide if the row as a whole matches the filters as a whole.
We're currently merging the filters before we're merging the columns, which I think doesn't work properly with multiple textSearchable columns - if again name and namespace are searchable, you wouldn't get a hit if one filter matches name and one filter matches namespace, only if all filters matches either name or namespace."

I'm absolutely 100% confused on the specifics of how we want this working so - TO BE WORKED OUT IN REFINEMENT:

  • Which/how many columns should be textSearchable on all tables? Name and namespace? Cluster for enterprise?
  • I'm lost in AND / OR. Will the filter have to match in all searchable columns or just one?
  • @opudrovs made a good point about notifying the user. If the user is expecting to search by name it'll be strange when certain rows show up based on their search matching the namespace. Right now we tell them absolutely nothing, so there's that.
@yiannistri yiannistri added the priority_low Items we want to complete in the next >= 90 days label Jun 5, 2023
@lasomethingsomething lasomethingsomething added area/ui Issues that require front-end work type/enhancement New feature or request labels Aug 16, 2023
@lasomethingsomething
Copy link
Contributor

Closing due to age and lack of detail. We can always reopen to revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work priority_low Items we want to complete in the next >= 90 days team/wild-watermelon type/enhancement New feature or request type/story
Projects
None yet
Development

No branches or pull requests

4 participants