router: tell goroutine to exit when forwarder is stopped

bboreham · bboreham · commit 27f8f9092fa3 · 2020-06-04T17:46:18.000Z
Otherwise a goroutine is leaked each time a connection is closed.
diff --git a/router/overlay_switch.go b/router/overlay_switch.go
@@ -452,6 +452,7 @@ func (fwd *overlaySwitchForwarder) Stop() {
 	fwd.lock.Lock()
 	defer fwd.lock.Unlock()
 	fwd.stopFrom(0)
+	close(fwd.stopChan)
 }
 
 func (fwd *overlaySwitchForwarder) ControlMessage(tag byte, msg []byte) {

Original file line number	Diff line number	Diff line change
`@@ -452,6 +452,7 @@ func (fwd *overlaySwitchForwarder) Stop() {`
`452`	`452`	`fwd.lock.Lock()`
`453`	`453`	`defer fwd.lock.Unlock()`
`454`	`454`	`fwd.stopFrom(0)`
	`455`	`+ close(fwd.stopChan)`
`455`	`456`	`}`
`456`	`457`
`457`	`458`	`func (fwd *overlaySwitchForwarder) ControlMessage(tag byte, msg []byte) {`