Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

add/remove DNS entries on network connect/disconnect #1914

Open
bboreham opened this issue Jan 20, 2016 · 4 comments
Open

add/remove DNS entries on network connect/disconnect #1914

bboreham opened this issue Jan 20, 2016 · 4 comments

Comments

@bboreham
Copy link
Contributor

Currently, weaveplugin listens for container started events, to know when to add a container name to DNS. We do some poking around in the API to see whether the container is actually connected to the weave network.

This approach is rather indirect, and misses docker network connect / disconnect.

In 1.10, Docker introduces network events, which give a much more direct way to achieve the requirement.

Given #813, we may be justified in requiring minimum Docker 1.10 when using the plugin.

@bboreham
Copy link
Contributor Author

bboreham commented Jun 1, 2016

Also, as noted on IRC, users can use --alias to give additional names in docker network connect, similar to #1975.

@rade rade changed the title Use Docker network events in the plugin add/remove DNS entries on network connect/disconnect Jun 1, 2016
@rade rade removed the icebox label Jun 1, 2016
@bboreham
Copy link
Contributor Author

bboreham commented Jun 14, 2016

Post #2374 we should also do the arp configuration on docker network connect

@dlmiddlecote
Copy link
Contributor

I'm going to work on this.

@bboreham
Copy link
Contributor Author

Thanks @dlmiddlecote - if you have any questions please ask here or in the Slack

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants