WEAVE_DOCKER_ARGS cause "invalid reference format" error

[bklau]

Symptom:

When attempting to pass additional Docker run arguments to weave launch, got an error "invalid reference format".
Found in version : Weave version2.4.0

Steps to repro:

Just execute the code below to add a custom Docker label "com.abc.com.container.ignore"
WEAVE_DEBUG= WEAVE_DOCKER_ARGS="-l com.abc.com.container.ignore" weave launch
unable to create container: API error (500): invalid reference format

Note: When WEAVE_DOCKER_ARGS="", it works.

[bboreham]

Hi, could you run WEAVE_DEBUG=true WEAVE_DOCKER_ARGS="-l com.abc.com.container.ignore" weave launch and post the full output please

[bklau]

WEAVE_DEBUG=true WEAVE_DOCKER_ARGS="-l com.abc.com.container.ignore" weave launch
/usr/local/bin/weave: 6: /usr/local/bin/weave: Bad substitution

[bklau]

WEAVE_DOCKER_ARGS="-l com.abc.com.container.ignore" weave launch
unable to create container: API error (500): invalid reference format

[bklau]

WEAVE_DEBUG= WEAVE_DOCKER_ARGS="-l com.abc.com.container.ignore" weave launch
unable to create container: API error (500): invalid reference format

[bklau]

Comment: There is a side bug unrelated with WEAVE_DEBUG

[bboreham]

Ah, ok, I think this is because weaveutil run_container doesn't support -l

Sorry about that.

[brb]

Fixed by #3371.