Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

[dns] failure during launch-dns can lead to long pause #393

Closed
bboreham opened this issue Feb 11, 2015 · 1 comment
Closed

[dns] failure during launch-dns can lead to long pause #393

bboreham opened this issue Feb 11, 2015 · 1 comment
Assignees
Milestone

Comments

@bboreham
Copy link
Contributor

If the weavedns container fails during start-up, but after the script gets into populate_dns, then it will take about 5 seconds to bail out because it doesn't check to see if the container is still running; it just repeatedly calls curl then sleep.

Also it doesn't check to see if a valid IP was returned from 'docker inspect'.

@inercia inercia self-assigned this Feb 13, 2015
@rade rade added the chore label Feb 17, 2015
@rade rade self-assigned this May 12, 2015
@rade
Copy link
Member

rade commented May 12, 2015

Looks like things have moved on since this was filed...

  1. We now wait for the dns container to respond to a status request, before doing anything else. This will catch any issues during dns container startup.
  2. Following that, we just invoke 'curl' for each container IP. That invocation has a configured connect timeout of 3 seconds. If it fails the weave script exits with an error code. There is no message though; I shall fix that.

@rade rade closed this as completed in 9195894 May 12, 2015
@rade rade added this to the 0.11.0 milestone Jan 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants