Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

[dns] tests take a long time to run #547

Closed
rade opened this issue Apr 11, 2015 · 0 comments
Closed

[dns] tests take a long time to run #547

rade opened this issue Apr 11, 2015 · 0 comments

Comments

@rade
Copy link
Member

rade commented Apr 11, 2015

$ go test -tags netgo github.com/weaveworks/weave/nameserver
ok      github.com/weaveworks/weave/nameserver  9.072s

Adding some debug logging and running the tests with -v reveals that most of that time is spent in shutting down dns servers. That turns out due to the way Shutdown is implemented in the DNS library we are using. The server sits in a loop that reads with a timeout and checks whether it should shut down every time the read returns. The default timeout is 2 seconds. This can be changed by setting Server.ReadTimeout.

@rade rade added the chore label Apr 11, 2015
@rade rade closed this as completed in 065b632 Apr 11, 2015
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants