Refactor shard status handling to use enum and update related tests

Author: mpartipilo

src/Weaviate.Client.Tests/Integration/TestCollectionShards.cs

@@ -29,8 +29,8 @@ public async Task Test_Should_Get_Collection_Shards()
             {
                 Assert.NotNull(shard.Name);
                 Assert.NotEmpty(shard.Name);
-                Assert.NotNull(shard.Status);
-                Assert.NotEmpty(shard.Status);
+                // Status is an enum, so it always has a value
+                Assert.True(Enum.IsDefined(typeof(ShardStatus), shard.Status));
             }
         );
     }
@@ -60,8 +60,7 @@ public async Task Test_Should_Get_Specific_Shard()
         // Assert
         Assert.NotNull(shard);
         Assert.Equal(firstShardName, shard.Name);
-        Assert.NotNull(shard.Status);
-        Assert.NotEmpty(shard.Status);
+        Assert.True(Enum.IsDefined(typeof(ShardStatus), shard.Status));
     }
 
     [Fact]
@@ -90,8 +89,7 @@ public async Task Test_Should_Update_Single_Shard_Status_To_ReadOnly()
         Assert.NotNull(updatedShards);
         Assert.Single(updatedShards);
         Assert.Equal(firstShardName, updatedShards[0].Name);
-        Assert.Equal("READONLY", updatedShards[0].Status);
-        Assert.Equal(ShardStatus.ReadOnly, updatedShards[0].StatusValue);
+        Assert.Equal(ShardStatus.ReadOnly, updatedShards[0].Status);
 
         // Cleanup: Set it back to READY
         await collection.Config.UpdateShardStatus(ShardStatus.Ready, firstShardName);
@@ -126,8 +124,7 @@ public async Task Test_Should_Update_Shard_Status_Back_To_Ready()
         Assert.NotNull(updatedShards);
         Assert.Single(updatedShards);
         Assert.Equal(firstShardName, updatedShards[0].Name);
-        Assert.Equal("READY", updatedShards[0].Status);
-        Assert.Equal(ShardStatus.Ready, updatedShards[0].StatusValue);
+        Assert.Equal(ShardStatus.Ready, updatedShards[0].Status);
     }
 
     [Fact]
@@ -156,7 +153,7 @@ public async Task Test_Should_Update_Multiple_Shards_With_Params()
         // Assert
         Assert.NotNull(updatedShards);
         Assert.Equal(shardNames.Length, updatedShards.Count);
-        Assert.All(updatedShards, shard => Assert.Equal("READONLY", shard.Status));
+        Assert.All(updatedShards, shard => Assert.Equal(ShardStatus.ReadOnly, shard.Status));
 
         // Cleanup: Set them all back to READY
         await collection.Config.UpdateShardStatus(ShardStatus.Ready, shardNames);

src/Weaviate.Client/Models/Shard.cs

@@ -1,3 +1,5 @@
+using System.Runtime.Serialization;
+
 namespace Weaviate.Client.Models;
 
 /// <summary>
@@ -8,16 +10,19 @@ public enum ShardStatus
     /// <summary>
     /// The shard is ready to serve requests.
     /// </summary>
+    [EnumMember(Value = "READY")]
     Ready,
 
     /// <summary>
     /// The shard is in read-only mode.
     /// </summary>
+    [EnumMember(Value = "READONLY")]
     ReadOnly,
 
     /// <summary>
     /// The shard is indexing data.
     /// </summary>
+    [EnumMember(Value = "INDEXING")]
     Indexing,
 }
 
@@ -32,27 +37,14 @@ public record ShardInfo
     public string Name { get; set; } = string.Empty;
 
     /// <summary>
-    /// Gets or sets the status of the shard (e.g., "READY", "READONLY", "INDEXING").
+    /// Gets or sets the status of the shard.
     /// </summary>
-    public string Status { get; set; } = string.Empty;
+    public ShardStatus Status { get; set; } = ShardStatus.Ready;
 
     /// <summary>
     /// Gets or sets the size of the vector queue for the shard.
     /// </summary>
     public int? VectorQueueSize { get; set; }
-
-    /// <summary>
-    /// Gets the parsed status as a ShardStatus enum.
-    /// Returns null if the status cannot be parsed.
-    /// </summary>
-    public ShardStatus? StatusValue =>
-        Status?.ToUpperInvariant() switch
-        {
-            "READY" => ShardStatus.Ready,
-            "READONLY" => ShardStatus.ReadOnly,
-            "INDEXING" => ShardStatus.Indexing,
-            _ => null,
-        };
 }
 
 /// <summary>
@@ -63,18 +55,14 @@ internal static class ShardStatusExtensions
     /// <summary>
     /// Converts a ShardStatus enum to its string representation for the API.
     /// </summary>
-    internal static string ToApiString(this ShardStatus status)
-    {
-        return status switch
-        {
-            ShardStatus.Ready => "READY",
-            ShardStatus.ReadOnly => "READONLY",
-            ShardStatus.Indexing => "INDEXING",
-            _ => throw new ArgumentOutOfRangeException(
-                nameof(status),
-                status,
-                "Unknown shard status value"
-            ),
-        };
-    }
+    internal static string ToApiString(this ShardStatus status) =>
+        WeaviateExtensions.ToEnumMemberString(status);
+
+    /// <summary>
+    /// Parses a string value to a ShardStatus enum.
+    /// </summary>
+    internal static ShardStatus ParseStatus(string? value) =>
+        string.IsNullOrEmpty(value)
+            ? ShardStatus.Ready
+            : WeaviateExtensions.FromEnumMemberString<ShardStatus>(value);
 }

src/Weaviate.Client/Rest/Dto/Extensions.cs

@@ -117,7 +117,7 @@ public Models.ShardInfo ToModel()
         return new Models.ShardInfo
         {
             Name = Name ?? string.Empty,
-            Status = Status ?? string.Empty,
+            Status = Models.ShardStatusExtensions.ParseStatus(Status),
             VectorQueueSize = VectorQueueSize,
         };
     }