Skip to content

Commit c984908

Browse files
Jinash RouniyarJinash Rouniyar
authored andcommitted
Updated support for knowledge param
1 parent b882822 commit c984908

File tree

4 files changed

+28
-0
lines changed

4 files changed

+28
-0
lines changed

src/collections/generate/config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ export const generativeParameters = {
319319
topP: config.topP,
320320
systemPrompt: config.systemPrompt,
321321
avoidCommentary: config.avoidCommentary,
322+
knowledge: config.knowledge,
322323
}
323324
: undefined,
324325
};

src/collections/generate/integration.test.ts

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,29 @@ maybeContextualAI('Testing of the collection.generate methods with Contextual AI
676676
}
677677
);
678678

679+
expect(response.objects).toHaveLength(1);
680+
expect(response.objects[0].generative).toBeDefined();
681+
expect(response.objects[0].generative?.text).toBeDefined();
682+
expect(typeof response.objects[0].generative?.text).toBe('string');
683+
});
684+
685+
it('should handle knowledge parameter override in runtime configuration', async () => {
686+
const response = await collection.generate.nearText(
687+
'machine learning',
688+
{
689+
singlePrompt: 'What is the custom knowledge?',
690+
config: generativeParameters.contextualai({
691+
model: 'v2',
692+
maxTokens: 100,
693+
temperature: 0.7,
694+
knowledge: ['Custom knowledge override', 'Additional context for testing'],
695+
}),
696+
},
697+
{
698+
limit: 1,
699+
}
700+
);
701+
679702
expect(response.objects).toHaveLength(1);
680703
expect(response.objects[0].generative).toBeDefined();
681704
expect(response.objects[0].generative?.text).toBeDefined();

src/collections/generate/unit.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ describe('Unit testing of the generativeParameters factory methods', () => {
332332
topP: 0.9,
333333
systemPrompt: 'sys',
334334
avoidCommentary: false,
335+
knowledge: ['knowledge1', 'knowledge2'],
335336
});
336337
expect(config).toEqual<
337338
ModuleConfig<
@@ -347,6 +348,7 @@ describe('Unit testing of the generativeParameters factory methods', () => {
347348
topP: 0.9,
348349
systemPrompt: 'sys',
349350
avoidCommentary: false,
351+
knowledge: ['knowledge1', 'knowledge2'],
350352
},
351353
});
352354
});

src/collections/types/generate.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ export type GenerativeConfigRuntimeType<G> = G extends 'generative-anthropic'
182182
topP?: number;
183183
systemPrompt?: string;
184184
avoidCommentary?: boolean;
185+
knowledge?: string[];
185186
}
186187
: G extends 'none'
187188
? undefined
@@ -347,4 +348,5 @@ export type GenerativeContextualAIConfigRuntime = {
347348
topP?: number | undefined;
348349
systemPrompt?: string | undefined;
349350
avoidCommentary?: boolean | undefined;
351+
knowledge?: string[] | undefined;
350352
};

0 commit comments

Comments
 (0)