feat: transform url in new URL without runtime (#11765)

Author: JSerFeng

crates/node_binding/napi-binding.d.ts

@@ -589,6 +589,7 @@ export declare enum BuiltinPluginName {
   RstestPlugin = 'RstestPlugin',
   RslibPlugin = 'RslibPlugin',
   CircularDependencyRspackPlugin = 'CircularDependencyRspackPlugin',
+  URLPlugin = 'URLPlugin',
   JsLoaderRspackPlugin = 'JsLoaderRspackPlugin',
   LazyCompilationPlugin = 'LazyCompilationPlugin',
   ModuleInfoHeaderPlugin = 'ModuleInfoHeaderPlugin',

crates/rspack_binding_api/src/raw_options/raw_builtins/mod.rs

@@ -64,7 +64,7 @@ use rspack_plugin_ignore::IgnorePlugin;
 use rspack_plugin_javascript::{
   FlagDependencyExportsPlugin, FlagDependencyUsagePlugin, InferAsyncModulesPlugin, JsPlugin,
   MangleExportsPlugin, ModuleConcatenationPlugin, SideEffectsFlagPlugin, api_plugin::APIPlugin,
-  define_plugin::DefinePlugin, provide_plugin::ProvidePlugin,
+  define_plugin::DefinePlugin, provide_plugin::ProvidePlugin, url_plugin::URLPlugin,
 };
 use rspack_plugin_json::JsonPlugin;
 use rspack_plugin_library::enable_library_plugin;
@@ -221,6 +221,7 @@ pub enum BuiltinPluginName {
   RstestPlugin,
   RslibPlugin,
   CircularDependencyRspackPlugin,
+  URLPlugin,
 
   // rspack js adapter plugins
   // naming format follow XxxRspackPlugin
@@ -301,6 +302,9 @@ impl<'a> BuiltinPlugin<'a> {
         .boxed();
         plugins.push(plugin);
       }
+      BuiltinPluginName::URLPlugin => {
+        plugins.push(URLPlugin::default().boxed());
+      }
       BuiltinPluginName::BannerPlugin => {
         let plugin = BannerPlugin::new(
           downcast_into::<RawBannerPluginOptions>(self.options)

crates/rspack_core/src/artifacts/code_generation_results.rs

@@ -37,6 +37,9 @@ impl CodeGenerationDataUrl {
 #[derive(Clone, Debug)]
 pub struct CodeGenerationPublicPathAutoReplace(pub bool);
 
+#[derive(Clone, Debug)]
+pub struct URLStaticMode;
+
 #[derive(Clone, Debug)]
 pub struct CodeGenerationDataFilename {
   filename: String,

crates/rspack_core/src/concatenated_module.rs

@@ -49,10 +49,10 @@ use crate::{
   ModuleGraphCacheArtifact, ModuleGraphConnection, ModuleIdentifier, ModuleLayer,
   ModuleStaticCacheArtifact, ModuleType, NAMESPACE_OBJECT_EXPORT, ParserOptions,
   PrefetchExportsInfoMode, Resolve, RuntimeCondition, RuntimeGlobals, RuntimeSpec, SourceType,
-  UsageState, UsedName, UsedNameItem, define_es_module_flag_statement, escape_identifier,
-  filter_runtime, get_runtime_key, impl_source_map_config, merge_runtime_condition,
-  merge_runtime_condition_non_false, module_update_hash, property_access, property_name,
-  reserved_names::RESERVED_NAMES, returning_function, runtime_condition_expression,
+  URLStaticMode, UsageState, UsedName, UsedNameItem, define_es_module_flag_statement,
+  escape_identifier, filter_runtime, get_runtime_key, impl_source_map_config,
+  merge_runtime_condition, merge_runtime_condition_non_false, module_update_hash, property_access,
+  property_name, reserved_names::RESERVED_NAMES, returning_function, runtime_condition_expression,
   subtract_runtime_condition, to_identifier_with_escaped, to_normal_comment,
 };
 
@@ -203,7 +203,8 @@ pub struct ConcatenatedModuleInfo {
   pub all_used_names: HashSet<Atom>,
   pub binding_to_ref: HashMap<(Atom, SyntaxContext), Vec<ConcatenatedModuleIdent>>,
 
-  pub public_path_auto_replace: Option<bool>,
+  pub public_path_auto_replacement: Option<bool>,
+  pub static_url_replacement: bool,
 }
 
 #[derive(Debug, Clone)]
@@ -705,6 +706,7 @@ impl Module for ConcatenatedModule {
 
     let mut top_level_declarations: HashSet<Atom> = HashSet::default();
     let mut public_path_auto_replace: bool = false;
+    let mut static_url_replace: bool = false;
 
     for (module_info_id, _raw_condition) in modules_with_info.iter() {
       let Some(ModuleInfo::Concatenated(info)) = module_to_info_map.get_mut(module_info_id) else {
@@ -937,9 +939,13 @@ impl Module for ConcatenatedModule {
           }
 
           // Handle publicPathAutoReplace for perf
-          if let Some(info_auto) = info.public_path_auto_replace {
+          if let Some(info_auto) = info.public_path_auto_replacement {
             public_path_auto_replace = public_path_auto_replace || info_auto;
           }
+
+          if info.static_url_replacement {
+            static_url_replace = true;
+          }
         }
 
         // Handle external type
@@ -1512,6 +1518,10 @@ impl Module for ConcatenatedModule {
         .insert(CodeGenerationPublicPathAutoReplace(true));
     }
 
+    if static_url_replace {
+      code_generation_result.data.insert(URLStaticMode);
+    }
+
     code_generation_result
       .data
       .insert(CodeGenerationDataTopLevelDeclarations::new(
@@ -2089,7 +2099,10 @@ impl ConcatenatedModule {
         .data
         .get::<CodeGenerationPublicPathAutoReplace>(
       ) {
-        module_info.public_path_auto_replace = Some(true);
+        module_info.public_path_auto_replacement = Some(true);
+      }
+      if codegen_res.data.contains::<URLStaticMode>() {
+        module_info.static_url_replacement = true;
       }
       Ok(ModuleInfo::Concatenated(Box::new(module_info)))
     } else {

crates/rspack_core/src/dependency/dependency_id.rs

@@ -11,6 +11,10 @@ impl DependencyId {
     let id = fetch_new_dependency_id();
     Self(id)
   }
+
+  pub fn as_u32(&self) -> u32 {
+    self.0
+  }
 }
 
 impl Default for DependencyId {

crates/rspack_core/src/options/module.rs

@@ -146,6 +146,7 @@ impl fmt::Display for DynamicImportFetchPriority {
 pub enum JavascriptParserUrl {
   Enable,
   Disable,
+  NewUrlRelative,
   Relative,
 }
 
@@ -154,6 +155,7 @@ impl From<&str> for JavascriptParserUrl {
     match value {
       "false" => Self::Disable,
       "relative" => Self::Relative,
+      "new-url-relative" => Self::NewUrlRelative,
       _ => Self::Enable,
     }
   }

crates/rspack_plugin_javascript/src/dependency/url/mod.rs

@@ -1,14 +1,18 @@
+use std::sync::LazyLock;
+
+use regex::Regex;
 use rspack_cacheable::{cacheable, cacheable_dyn, with::AsPreset};
 use rspack_core::{
-  AsContextDependency, ConnectionState, Dependency, DependencyCategory, DependencyCodeGeneration,
-  DependencyCondition, DependencyConditionFn, DependencyId, DependencyRange, DependencyTemplate,
-  DependencyTemplateType, DependencyType, FactorizeInfo, ModuleDependency, ModuleGraph,
-  ModuleGraphCacheArtifact, ModuleGraphConnection, RuntimeGlobals, RuntimeSpec, TemplateContext,
-  TemplateReplaceSource, UsedByExports, module_id,
+  AsContextDependency, CodeGenerationPublicPathAutoReplace, ConnectionState, Dependency,
+  DependencyCategory, DependencyCodeGeneration, DependencyCondition, DependencyConditionFn,
+  DependencyId, DependencyRange, DependencyTemplate, DependencyTemplateType, DependencyType,
+  FactorizeInfo, JavascriptParserUrl, ModuleDependency, ModuleGraph, ModuleGraphCacheArtifact,
+  ModuleGraphConnection, RuntimeGlobals, RuntimeSpec, TemplateContext, TemplateReplaceSource,
+  URLStaticMode, UsedByExports, module_id,
 };
 use swc_core::ecma::atoms::Atom;
 
-use crate::connection_active_used_by_exports;
+use crate::{connection_active_used_by_exports, runtime::AUTO_PUBLIC_PATH_PLACEHOLDER};
 
 #[cacheable]
 #[derive(Debug, Clone)]
@@ -19,7 +23,7 @@ pub struct URLDependency {
   range: DependencyRange,
   range_url: DependencyRange,
   used_by_exports: Option<UsedByExports>,
-  relative: bool,
+  mode: Option<JavascriptParserUrl>,
   factorize_info: FactorizeInfo,
 }
 
@@ -28,15 +32,15 @@ impl URLDependency {
     request: Atom,
     range: DependencyRange,
     range_url: DependencyRange,
-    relative: bool,
+    mode: Option<JavascriptParserUrl>,
   ) -> Self {
     Self {
       id: DependencyId::new(),
       request,
       range,
       range_url,
       used_by_exports: None,
-      relative,
+      mode,
       factorize_info: Default::default(),
     }
   }
@@ -105,6 +109,11 @@ impl AsContextDependency for URLDependency {}
 #[derive(Debug, Clone, Default)]
 pub struct URLDependencyTemplate;
 
+pub static URL_STATIC_PLACEHOLDER: &str = "RSPACK_AUTO_URL_STATIC_PLACEHOLDER_";
+pub static URL_STATIC_PLACEHOLDER_RE: LazyLock<Regex> = LazyLock::new(|| {
+  Regex::new(&format!(r#"{}(?<dep>\d+)"#, URL_STATIC_PLACEHOLDER)).expect("should be valid regex")
+});
+
 impl URLDependencyTemplate {
   pub fn template_type() -> DependencyTemplateType {
     DependencyTemplateType::Dependency(DependencyType::NewUrl)
@@ -130,34 +139,57 @@ impl DependencyTemplate for URLDependencyTemplate {
 
     runtime_requirements.insert(RuntimeGlobals::REQUIRE);
 
-    if dep.relative {
-      runtime_requirements.insert(RuntimeGlobals::RELATIVE_URL);
-      source.replace(
-        dep.range.start,
-        dep.range.end,
-        format!(
-          "/* asset import */ new {}({}({}))",
-          RuntimeGlobals::RELATIVE_URL,
-          RuntimeGlobals::REQUIRE,
-          module_id(compilation, &dep.id, &dep.request, false),
-        )
-        .as_str(),
-        None,
-      );
-    } else {
-      runtime_requirements.insert(RuntimeGlobals::BASE_URI);
-      source.replace(
-        dep.range_url.start,
-        dep.range_url.end,
-        format!(
-          "/* asset import */{}({}), {}",
-          RuntimeGlobals::REQUIRE,
-          module_id(compilation, &dep.id, &dep.request, false),
-          RuntimeGlobals::BASE_URI
-        )
-        .as_str(),
-        None,
-      );
+    match dep.mode {
+      Some(JavascriptParserUrl::Relative) => {
+        runtime_requirements.insert(RuntimeGlobals::RELATIVE_URL);
+        source.replace(
+          dep.range.start,
+          dep.range.end,
+          format!(
+            "/* asset import */ new {}({}({}))",
+            RuntimeGlobals::RELATIVE_URL,
+            RuntimeGlobals::REQUIRE,
+            module_id(compilation, &dep.id, &dep.request, false),
+          )
+          .as_str(),
+          None,
+        );
+      }
+      Some(JavascriptParserUrl::NewUrlRelative) => {
+        code_generatable_context.data.insert(URLStaticMode);
+        code_generatable_context
+          .data
+          .insert(CodeGenerationPublicPathAutoReplace(true));
+        source.replace(
+          dep.range.start,
+          dep.range.end,
+          format!(
+            "new URL({}, import.meta.url)",
+            serde_json::to_string(&format!(
+              "{AUTO_PUBLIC_PATH_PLACEHOLDER}{URL_STATIC_PLACEHOLDER}{}",
+              &dep.id.as_u32()
+            ))
+            .expect("should serde"),
+          )
+          .as_str(),
+          None,
+        );
+      }
+      _ => {
+        runtime_requirements.insert(RuntimeGlobals::BASE_URI);
+        source.replace(
+          dep.range_url.start,
+          dep.range_url.end,
+          format!(
+            "/* asset import */{}({}), {}",
+            RuntimeGlobals::REQUIRE,
+            module_id(compilation, &dep.id, &dep.request, false),
+            RuntimeGlobals::BASE_URI
+          )
+          .as_str(),
+          None,
+        );
+      }
     }
   }
 }

crates/rspack_plugin_javascript/src/parser_plugin/url_plugin.rs

@@ -1,4 +1,4 @@
-use rspack_core::{ConstDependency, RuntimeGlobals};
+use rspack_core::{ConstDependency, JavascriptParserUrl, RuntimeGlobals};
 use rspack_util::SpanExt;
 use swc_core::{
   common::Spanned,
@@ -45,7 +45,7 @@ pub fn get_url_request(
 }
 
 pub struct URLPlugin {
-  pub relative: bool,
+  pub mode: Option<JavascriptParserUrl>,
 }
 
 impl JavascriptParserPlugin for URLPlugin {
@@ -96,7 +96,7 @@ impl JavascriptParserPlugin for URLPlugin {
         request.into(),
         expr.span.into(),
         (start, end).into(),
-        self.relative,
+        self.mode,
       );
       let dep_idx = parser.next_dependency_idx();
       parser.add_dependency(Box::new(dep));

crates/rspack_plugin_javascript/src/plugin/mod.rs

@@ -16,6 +16,7 @@ pub mod infer_async_modules_plugin;
 mod mangle_exports_plugin;
 pub mod module_concatenation_plugin;
 mod side_effects_flag_plugin;
+pub mod url_plugin;
 
 pub use drive::*;
 pub use flag_dependency_exports_plugin::*;