You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing @rspack/cli in a repo backed by pnpm with strict peer dependencies enabled, you get this error:
../../heft-plugins/heft-rspack-plugin # This is an arbitrary package path
└─┬ @rspack/cli 0.1.1
└─┬ @rspack/dev-server 0.1.1
├─┬ webpack-dev-server 4.11.1
│ ├── ✕ missing peer webpack@"^4.37.0 || ^5.0.0"
│ └─┬ webpack-dev-middleware 5.3.3
│ └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
└─┬ @rspack/dev-middleware 0.1.1
└─┬ webpack-dev-middleware 6.0.0
└── ✕ missing peer webpack@^5.0.0
Peer dependencies that should be installed:
webpack@">=5.0.0 <6.0.0"
@rspack/dev-server has a dependency on webpack-dev-server and @rspack/dev-middleware has a dependency on webpack-dev-middleware which both have peerDependencies on webpack.
yes this is by design right now, since we reuse lots of webpack related packages right now to avoid incompatible with webpack, I am wondering whether webpack-dev-middleware could list webpack as optionalPeerDependency other than peerDependency which could solve this problem.
System Info
System:
OS: Windows 10 10.0.22623
CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
Memory: 35.40 GB / 63.84 GB
Binaries:
Node: 16.19.0 - ~\AppData\Local\nvs\default\node.EXE
Yarn: 1.22.19 - ~\AppData\Local\nvs\default\yarn.CMD
npm: 8.19.3 - ~\AppData\Local\nvs\default\npm.CMD
Browsers:
Chrome: 111.0.5563.65
Edge: Spartan (44.22621.1325.0), Chromium (109.0.1518.61), ChromiumDev (107.0.1387.2)
Internet Explorer: 11.0.22621.1
npmPackages:
@rspack/cli: ^0.1.1 => 0.1.1
This information doesn't matter for this issue.
Details
When installing
@rspack/cli
in a repo backed by pnpm with strict peer dependencies enabled, you get this error:@rspack/dev-server
has a dependency onwebpack-dev-server
and@rspack/dev-middleware
has a dependency onwebpack-dev-middleware
which both have peerDependencies onwebpack
.Reproduce link
No response
Reproduce Steps
In an empty folder, run:
pnpm init
pnpm install @rspack/cli --save --strict-peer-dependencies
The text was updated successfully, but these errors were encountered: