Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: pitching loader support #2394

Closed
Tracked by #2048
, #2350
...
ahabhgk opened this issue Mar 21, 2023 · 2 comments · Fixed by #2808
Closed
Tracked by #2048
, #2350
...

[Feature Request]: pitching loader support #2394

ahabhgk opened this issue Mar 21, 2023 · 2 comments · Fixed by #2808
Assignees
@h-a-n-a
Labels
team The issue/pr is created by the member of Rspack.

Comments

@ahabhgk
Copy link
Contributor

ahabhgk commented Mar 21, 2023

https://webpack.js.org/api/loaders/#pitching-loader
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 21, 2023
@ahabhgk ahabhgk mentioned this issue Mar 21, 2023
Closed
@ahabhgk ahabhgk self-assigned this Mar 21, 2023
@ScriptedAlchemy
Copy link
Contributor

Pitching loader support is a biggie! I almost exclusively use pitch loaders for augmenting applications.

Will pitch loaders support this.loadModule or this.importModule?

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Mar 22, 2023

Pitching loader is needed for vue-loader, if there are any common uses loader relying on loadModule or importModule, we will also support these two API

@ahabhgk ahabhgk added this to the backlog milestone Mar 22, 2023
@hardfist hardfist added the P0 label Mar 28, 2023
@Boshen Boshen mentioned this issue Apr 3, 2023
Closed
@IWANABETHATGUY IWANABETHATGUY modified the milestones: backlog, Planned Apr 4, 2023
@h-a-n-a h-a-n-a changed the title pitching loader support [Feature Request]: pitching loader support Apr 6, 2023
@ahabhgk ahabhgk removed their assignment Apr 19, 2023
@h-a-n-a h-a-n-a mentioned this issue Apr 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-a-n-a h-a-n-a

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support loader-runner and pitching web-infra-dev/rspack
5 participants
@hardfist @h-a-n-a @IWANABETHATGUY @ScriptedAlchemy @ahabhgk