-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support contextModuleFactory beforeResolve hook #6420
Merged
SyMind
merged 14 commits into
web-infra-dev:main
from
SyMind:moment-locales-webpack-plugin
May 10, 2024
Merged
feat: support contextModuleFactory beforeResolve hook #6420
SyMind
merged 14 commits into
web-infra-dev:main
from
SyMind:moment-locales-webpack-plugin
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Apr 30, 2024
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
SyMind
force-pushed
the
moment-locales-webpack-plugin
branch
from
May 9, 2024 09:35
7ea5bec
to
c693c7a
Compare
SyMind
force-pushed
the
moment-locales-webpack-plugin
branch
from
May 9, 2024 13:24
0d3cfe2
to
390745f
Compare
!bench |
📝 Benchmark detail: Open
|
SyMind
changed the title
feat: support contextModuleFactory afterResolve hook
feat: support contextModuleFactory beforeResolve hook
May 10, 2024
JSerFeng
approved these changes
May 10, 2024
!eco-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #6373
We should implement the following hooks:
ContextModuleFactory.beforeResolve
ContextModuleFactory.afterResolve
Implementing all the parameters supported by the hooks is very challenging, so for this iteration, we will only implement the following parameters:
Checklist