-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(diagnostic): improve diagnostics for swc wasm plugins when mismatch #8001
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What is the context? |
I think the motivation for this PR is to add the test case back, @SyMind right? |
We can change the PR title to make it more accurate. |
@hardfist let me revert this PR. Initially, I thought Therefore, I believe I misunderstood the purpose of this PR. We need @hardfist to take a look at it. |
swc support throw error when wasm binary not match now, so it's safe to add this test case back without enabling catch_on_unwind another block in swc side https://github.com/swc-project/swc/blob/main/crates/swc/src/plugin.rs#L169, we need to remove the panic here first |
5761426
to
4ab5522
Compare
This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump"). |
Summary
improve diagnostics when wasm plugin binary format mismatch
Checklist